cli/command/system: add shell completion for "docker inspect"#6444
Merged
thaJeztah merged 1 commit intodocker:masterfrom Sep 10, 2025
Merged
cli/command/system: add shell completion for "docker inspect"#6444thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
The "docker inspect" command can inspect any type of object, which would require all possible endpoints to be contacted. By default, we don't provide completion, but if a `--type` is passed, we provide completion for the given type. For example, `docker inspect --type container` will complete container names, `docker inspect --type volume` will complete volume names and so on. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
commented
Sep 9, 2025
Comment on lines
+322
to
+323
| // TODO(thaJeztah): completion functions in this package don't remove names that have already been completed | ||
| // this causes completion to continue even if a given name was already completed. |
Member
Author
There was a problem hiding this comment.
This is something to fix; I think I fixed this in some other places, but currently the completion functions don't take existing completions into account, so (e.g.) if there's a single container named foo, then pressing tab will continue to provide foo as completion.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
vvoland
approved these changes
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "docker inspect" command can inspect any type of object, which would require all possible endpoints to be contacted. By default, we don't provide completion, but if a
--typeis passed, we provide completion for the given type.For example,
docker inspect --type containerwill complete container names,docker inspect --type volumewill complete volume names and so on.- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)