cli/command: remove prompt utilities that were for internal use#6243
Merged
thaJeztah merged 1 commit intodocker:masterfrom Aug 6, 2025
Merged
cli/command: remove prompt utilities that were for internal use#6243thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
- The `DisableInputEcho` and `PromptForInput` utilities were added in c15ade0 as part of a bug-fix, which was part of v28.x. [There are no (publicly visible) users][1] of either. - The `ErrPromptTerminated` was added in v26.x (originally added in 10bf91a, later updated in commit 7c722c0. [It is not used][2] - The `PromptForConfirmation` was added in [moby@280c872] (docker v1.13.0) as part of the `docker <object> prune` subcommands. It was meant for internal use but exported to allow re-using it in the `container`, `image` (etc.) packages. However, a breaking change to its signature was made in 10bf91a. It currently does [not appear to have any (public) users][2]. This patch removes the `ErrPromptTerminated`, `DisableInputEcho`, `PromptForInput`, and `PromptForConfirmation` utilities from the `cli/command` package. The core functionality of these is still available in the `internal/prompt` package, which we may make public at some point, but still needs some refining / decoupling. [moby@280c872]: moby/moby@280c872 [1]: https://grep.app/search?f.lang=Go®exp=true&q=%5C.%28DisableInputEcho%7CPromptForInput%29%5C%28 [2]: https://grep.app/search?f.lang=Go&q=%5C.ErrPromptTerminated [3]: https://grep.app/search?f.lang=Go&q=.PromptForConfirmation%28 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Benehiko
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
cli/command: remove prompt utilities that were for internal use
DisableInputEchoandPromptForInpututilities were added in c15ade0 as part of a bug-fix, which was part of v28.x. There are no (publicly visible) users of either.ErrPromptTerminatedwas added in v26.x (originally added in 10bf91a, later updated in commit 7c722c0. It is not usedPromptForConfirmationwas added in moby@280c872 (docker v1.13.0) as part of thedocker <object> prunesubcommands. It was meant for internal use but exported to allow re-using it in thecontainer,image(etc.) packages. However, a breaking change to its signature was made in 10bf91a. It currently does not appear to have any (public) users.This patch removes the
ErrPromptTerminated,DisableInputEcho,PromptForInput, andPromptForConfirmationutilities from thecli/commandpackage. The core functionality of these is still available in theinternal/promptpackage, which we may make public at some point, but still needs some refining / decoupling.- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)