build: remove DCT support for classic builder#6195
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jul 21, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
14676fe to
6d531d9
Compare
Docker Content Trust is currently only implemented for the classic
builder, but is known to not work with multi-stage builds, and
requires rewriting the Dockerfile, which is brittle because the
Dockerfile syntax evolved with the introduction of BuildKit as
default builder.
Given that the classic builder is deprecated, and only used for
Windows images, which are not verified by content trust;
# docker pull --disable-content-trust=false mcr.microsoft.com/windows/servercore:ltsc2025
Error: remote trust data does not exist for mcr.microsoft.com/windows/servercore: mcr.microsoft.com does not have trust data for mcr.microsoft.com/windows/servercore
With content trust not implemented in BuildKit, and not implemented
in docker compose, this resulted in an inconsistent behavior.
This patch removes content-trust support for "docker build". As this
is a client-side feature, users who require this feature can still
use an older CLI to to start the build.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
tianon-sso
approved these changes
Jul 21, 2025
tianon
approved these changes
Jul 21, 2025
neersighted
approved these changes
Jul 21, 2025
matt9ucci
added a commit
to matt9ucci/DockerCompletion
that referenced
this pull request
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker Content Trust is currently only implemented for the classic builder, but is known to not work with multi-stage builds, and requires rewriting the Dockerfile, which is brittle because the Dockerfile syntax evolved with the introduction of BuildKit as default builder.
Given that the classic builder is deprecated, and only used for Windows images, which are not verified by content trust;
With content trust not implemented in BuildKit, and not implemented in docker compose, this resulted in an inconsistent behavior.
This patch removes content-trust support for "docker build". As this is a client-side feature, users who require this feature can still use an older CLI to to start the build.
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)