login: add oauth escape hatch#5361
Merged
laurazard merged 2 commits intodocker:masterfrom Aug 20, 2024
Merged
Conversation
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Signed-off-by: Laura Brehm <laurabrehm@hey.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5361 +/- ##
==========================================
- Coverage 61.51% 60.93% -0.58%
==========================================
Files 303 304 +1
Lines 21130 21347 +217
==========================================
+ Hits 12998 13008 +10
- Misses 7203 7409 +206
- Partials 929 930 +1 |
vvoland
approved these changes
Aug 20, 2024
Benehiko
approved these changes
Aug 20, 2024
This was referenced Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Add an escape hatch (
DOCKER_CLI_DISABLE_OAUTH_LOGIN) to turn off new login flow.- How I did it
- How to verify it
docker loginDOCKER_CLI_DISABLE_OAUTH_LOGIN=1 docker loginDOCKER_CLI_DISABLE_OAUTH_LOGIN=0 docker loginDOCKER_CLI_DISABLE_OAUTH_LOGIN=true docker loginDOCKER_CLI_DISABLE_OAUTH_LOGIN=false docker login- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)