use local ConvertToHostname() implementation#3599
Merged
vvoland merged 1 commit intodocker:masterfrom Jun 20, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3599 +/- ##
==========================================
+ Coverage 61.76% 61.78% +0.01%
==========================================
Files 297 297
Lines 20768 20768
==========================================
+ Hits 12828 12831 +3
+ Misses 7024 7023 -1
+ Partials 916 914 -2 |
Member
Author
Contributor
|
I don't think "Copied from github.com/docker/docker/registry.ConvertToHostname to reduce dependencies" makes our codebase better.
imho it would make more sense for such utility func to be shared between cli and engine within one of the |
ab2bdbc to
713297d
Compare
Commit 27b2797 added a local implementation of this function, so let's use the local variant to (slightly) reduce the dependency on moby's registry package. Also made some minor cleanups. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
713297d to
8376b3e
Compare
vvoland
approved these changes
Jun 20, 2024
This was referenced Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 27b2797 (#1642) added a local implementation of this function, so let's use the local variant to (slightly) reduce the dependency on moby's registry package.
Also made some minor cleanups.
- A picture of a cute animal (not mandatory but encouraged)