Pre-Release #12
Merged
Pre-Release #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The player 1 link is better for more direct debugging, but if you've never used the site before it's not as clear and might be confusing to first time users.
It's better to point the user to more information rather than just throwing a blanket error that says "you can't do that"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains two tiny changes to prep for the first public release.
First, I changed the link to GamepadViewer.com to go to the homepage rather than the player 1 display, which might be confusing if you've never used the site before.
Second, I changed the
#errormessage if no recognized board is found to also mention the supported boards file in the 'extras' folder, which should help if someone downloads the library from the library manager and doesn't read the description about requiring an external boards package.