Fixed #36284, Refs #31170 -- Ensured related lookup popups are closed properly. #19328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properly. In the admin, when selecting related objects via the helpers defined in `RelatedObjectLookups.js`, the `dismissRelatedLookupPopup` function was attempting to access `window.relatedWindows`, which does not exist in real execution, causing related lookup popups to remain open. This change ensures that this code correctly accesses the module-local `relatedWindows` by explicitly assigning it to `window.relatedWindows`. Regression in 91bebf1. Thanks Matthias Kestenholz for the report and for test further testing. Co-authored-by: Matthias Kestenholz <[email protected]>
|
@matthiask Hi! Thanks for your ticket and assistance. 🌟 |
matthiask
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36284
Branch description
In the admin, when selecting related objects via the helpers defined in
RelatedObjectLookups.js, thedismissRelatedLookupPopupfunction was attempting to accesswindow.relatedWindows, which does not exist in real execution, causing related lookup popups to remain open.This change ensures that this code correctly accesses the module-local
relatedWindowsby explicitly assigning it towindow.relatedWindows.Regression in 91bebf1.
Thanks Matthias Kestenholz for the report and for test further testing.
Checklist
mainbranch.