Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input improvements and Text Settings cleanup #2189

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

Jowan-Spooner
Copy link
Collaborator

@Jowan-Spooner Jowan-Spooner commented Apr 18, 2024

Thanks so much to @StrangeLost to bringing this to my attention and providing a MRP!

  • uses is_action_JUST_pressed for input handling, avoiding issues where by having the mouse pressed and moving while advancing, you could trigger advance twice.
  • move skip delay blocking to the beginning of text events
  • expose "Advance Delay"
  • cleanup text settings scene/script

@Jowan-Spooner Jowan-Spooner added Bug 🐞 Something isn't working Enhance ⚡ Improve a feature's workflow. Feature✨ labels Apr 18, 2024
@Jowan-Spooner Jowan-Spooner merged commit f3b0604 into dialogic-godot:main Apr 18, 2024
2 checks passed
@Jowan-Spooner Jowan-Spooner deleted the input-improvements branch July 8, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 Something isn't working Enhance ⚡ Improve a feature's workflow. Feature✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant