Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple improvements/fixes #1886

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Multiple improvements/fixes #1886

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0539792
Change small margin
Jowan-Spooner Nov 9, 2023
8f50c85
Fix pause effect not working
Jowan-Spooner Nov 9, 2023
0e5f99a
Make sure deleted files are closed correctly
Jowan-Spooner Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix pause effect not working
  • Loading branch information
@Jowan-Spooner
Jowan-Spooner committed Nov 9, 2023
commit 8f50c857e3ce5b7f7ab1a8ab0bacd05d9d0b048f
5 changes: 2 additions & 3 deletions addons/dialogic/Modules/Text/subsystem_text.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,13 +376,12 @@ func effect_pause(text_node:Control, skipped:bool, argument:String) -> void:
return

# We want to ignore pauses if we're skipping.
if not dialogic.Input.auto_skip.enabled:
if dialogic.Input.auto_skip.enabled:
return

var text_speed = Dialogic.Settings.get_setting('text_speed', 1)
var text_speed: float = Dialogic.Settings.get_setting('text_speed', 1)

if argument:

if argument.ends_with('!'):
await get_tree().create_timer(float(argument.trim_suffix('!'))).timeout
elif speed_multiplier != 0 and Dialogic.Settings.get_setting('text_speed', 1) != 0:
Expand Down