Minimal changes to allow post-execution sequence verification#1605
Open
PatrickScottDS wants to merge 3 commits intodevlooped:mainfrom
Open
Minimal changes to allow post-execution sequence verification#1605PatrickScottDS wants to merge 3 commits intodevlooped:mainfrom
PatrickScottDS wants to merge 3 commits intodevlooped:mainfrom
Conversation
…ence verification
…ey can be used for sequence verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a fully-realized API for sequence verification, but instead a minimal set of changes that exposes enough information to allow users to write their own sequence verification utilities that meet their specific needs. Existing user code can only inspect the
mock.Invocationslist for this purpose but with two major drawbacks: the order of invocations between separate mocks is unknown and filtering the list cumbersome without the expression matching functionality ofmock.Setup(...)andmock.Verify(...).These issues are addressed as follows:
Invocation.Invocations frommock.Verify(...)(and all of its variations) as a convenient way of filtering the invocation list.