Compatibility fixes for Go 1.6 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes compatibility with Go 1.6, which specifies stricter rules for passing Go pointers to C and vice versa. Exported methods now use the C context's pointer hexadecimal representation to find the parent Go Context.
Closed
Several API-breaking changes: * Define method and related functionality moved back to Engine package * Exported functions for receivers moved to the engine package * Receiver API cleaned up and made public Receivers no longer store Go pointers in C contexts, and instead use the C engine_receiver pointer as reference in the Go context (similar to what we do for Contexts). Some changes have been made to the C code to accomodate the above.
borancar
pushed a commit
to borancar/go-php
that referenced
this pull request
Dec 1, 2019
Feature/amazon Approved-by: Matthew Tyas <matthew.tyas@antstream.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with Go 1.6 and passing of Go pointers down to C functions. For reference, see this proposal.
Linked issue: #17