Skip to content

Conversation

@stasadev
Copy link
Member

@stasadev stasadev commented Sep 3, 2025

The Issue

How This PR Solves The Issue

Using https://github.com/ddev/ddev/blob/4b5686665ba136867e7252cd080e9a31bc3f83d5/pkg/ddevapp/config.go#L1367-L1368 technique to fix failing build.

Manual Testing Instructions

On MacOS 15.6 + Docker Desktop:

ddev config --webserver-type=generic
ddev add-on get https://github.com/stasadev/ddev-frankenphp/tarball/refs/pull/24/head
ddev restart

$ ddev exec -s frankenphp 'whoami && id -u && id -g'
testbot
501
1000

$ ddev exec 'whoami && id -u && id -g'
testbot
501
20

Automated Testing Overview

Release/Deployment Notes

@stasadev stasadev requested a review from rfay September 3, 2025 22:01
@stasadev stasadev changed the title fix: add user in the same it's done in DDEV core, fixes #22 fix: add user the same way as in DDEV core, fixes #22 Sep 3, 2025
Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it should be fine. The intent is just to use the same username/uid/gid as the user on the host, but do something else if necessary.

@stasadev stasadev merged commit 26d2409 into main Sep 3, 2025
2 checks passed
@stasadev stasadev deleted the 20250904_stasadev_user branch September 3, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MacOS: Build fails with groupadd: GID '20' already exists

3 participants