Adding preset for Commodore 1581 (cbm1581) to IBM writer frontend#218
Merged
davidgiven merged 1 commit intodavidgiven:masterfrom Feb 16, 2021
Merged
Conversation
Owner
|
Sorry for the delay --- working on other projects. Yup, LGTM. |
Owner
|
Merged. Thanks! |
davidgiven
pushed a commit
that referenced
this pull request
Dec 5, 2021
Adding preset for Commodore 1581 (cbm1581) to IBM writer frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Now this change is just a proposal - in two ways:
First, my preset for Commodore 1581 might not fit in well in this file - maybe it should get its own source file. (Especially as in a couple of days/weeks I will come up with a preset for CMD FD-2000 once I have found somebody who owns one and can confirm that the preset is ok. Some details regarding FD-2000 are in #107)
Secondly, the gap values of the 1581 preset are good enough for me and my tests with a real 1581 drive but might be matter of change once somebody reviews them / looks at diagrams, etc.
So this is just the current state of things and if you want - merge it, if not, it's ok for me - I can play with my 1581 images locally anyway.