Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix several datetime errors [sc-100369] #266

Closed
wants to merge 1 commit into from
Closed

Fix several datetime errors [sc-100369] #266

wants to merge 1 commit into from

Conversation

marchelleboid
Copy link
Contributor

Tested in both python2 and python3.

[sc-100369]

@marchelleboid marchelleboid added this to the V 11.1.0 milestone Sep 15, 2022
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #100369: Python API client: Error when calling the DSSUserActivity properties.

NawreCode
NawreCode approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@NawreCode NawreCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with python 2.7 and 3.8.

I'm a bit surprised we didn't see the issue sooner, especially when Eric has added the createdOn attribute 🥲

@marchelleboid
Copy link
Contributor Author

Closing: PR was moved.

@marchelleboid marchelleboid deleted the fix/dss111-sc-100369-fix-datetime-errors-in-admin branch September 21, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NawreCode NawreCode NawreCode approved these changes

@FChataigner FChataigner FChataigner approved these changes

Assignees
No one assigned
Labels
theme-platform
Projects
None yet
Milestone
V 11.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marchelleboid @NawreCode @FChataigner