govern public api fixes #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldelille
approved these changes
Aug 30, 2022
| @@ -203,6 +206,10 @@ def __init__(self, blueprint_ids=None): | |||
| self.blueprint_ids = blueprint_ids if blueprint_ids is not None else [] | |||
|
|
|||
| def build(self): | |||
| """ | |||
There was a problem hiding this comment.
Should this method be documented ? The user should not use it in theory
| to create blueprint version ids from blueprint ids and versions ids. | ||
| """ | ||
| super(GovernArtifactSearchSourceBlueprintVersions, self).__init__(search_source_type="blueprintVersions") | ||
| self.blueprint_version_ids = blueprint_version_ids if blueprint_version_ids is not None else [] | ||
|
|
||
| def build(self): | ||
| """ | ||
| :returns: the search source definition as a dict | ||
| :rtype: dict |
| @@ -239,17 +250,20 @@ def __init__(self, artifact_ids=None): | |||
| self.artifact_ids = artifact_ids if artifact_ids is not None else [] | |||
|
|
|||
| def build(self): | |||
| """ | |||
| :returns: the search source definition as a dict | |||
| """ | ||
| super(GovernArtifactSearchSortName, self).__init__(artifact_search_sort_type="name", direction=direction) | ||
|
|
||
| def build(self): | ||
| """ | ||
| :returns: the search sort definition as a dict |
| """ | ||
| super(GovernArtifactSearchSortWorkflow, self).__init__(artifact_search_sort_type="workflow", direction=direction) | ||
|
|
||
| def build(self): | ||
| """ | ||
| :returns: the search sort definition as a dict |
ldelille
reviewed
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.