Skip to content

bug fix : no_fail argument passed #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2022
Merged

bug fix : no_fail argument passed #241

merged 1 commit into from
May 30, 2022

Conversation

gambinoga
Copy link
Contributor

The no_fail argument was not passed to the stard_and_wait() method

@gambinoga gambinoga added the team-mielpops Team MieL pOps label May 25, 2022
@gambinoga gambinoga added this to the 11. milestone May 25, 2022
@gambinoga gambinoga requested a review from marchelleboid May 25, 2022 16:54
marchelleboid
marchelleboid approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@marchelleboid marchelleboid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@gambinoga gambinoga merged commit 8976d20 into master May 30, 2022
@instanceofme instanceofme removed this from the 11. milestone Sep 7, 2022
@instanceofme
Copy link
Contributor

Cleared the 11. (sic) milestone. Can you put the proper milestone please?
Also, is it normal that this targets / was merged in master if it is for 11.something?

@lpenet lpenet added this to the V 11.0.0 milestone Sep 7, 2022
@lpenet
Copy link
Contributor

lpenet commented Sep 7, 2022

Cleared the 11. (sic) milestone. Can you put the proper milestone please? Also, is it normal that this targets / was merged in master if it is for 11.something?

The milestone is 11.0.0. IIRC, we branches the public API later than dip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marchelleboid marchelleboid marchelleboid approved these changes

Assignees
No one assigned
Labels
team-mielpops Team MieL pOps
Projects
None yet
Milestone
V 11.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gambinoga @instanceofme @lpenet @marchelleboid