Skip to content

Conversation

@ari-nz
Copy link
Contributor

@ari-nz ari-nz commented May 6, 2022

Add more REST api functionality to the python SDK

Issue #456

@codecov-commenter
Copy link

codecov-commenter commented May 6, 2022

Codecov Report

Merging #457 (c33aa30) into master (e427730) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #457   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files          42       42           
  Lines        3144     3144           
=======================================
  Hits         2667     2667           
  Misses        477      477           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e427730...c33aa30. Read the comment docs.

@nfx nfx linked an issue May 6, 2022 that may be closed by this pull request
@ari-nz
Copy link
Contributor Author

ari-nz commented May 10, 2022

@nfx - I've added a few more tests. Let me know if there's anything else specific that you need.

@ari-nz ari-nz requested a review from nfx May 10, 2022 01:11
@ari-nz
Copy link
Contributor Author

ari-nz commented Jul 20, 2022

@nfx I've rebased this fork back onto the latest version of main. It looks like the create_job api has been updated, but not the update_job

Requesting this PR to be merged

@ari-nz
Copy link
Contributor Author

ari-nz commented Jul 20, 2022

Tagging @pietern too as it looks like you've been actively lately :)

@pietern
Copy link
Contributor

pietern commented Aug 18, 2022

@ari-nz Thanks for the ping. We've picked up generating service.py from an internal definition of the API as of a couple of months ago, which is why the updated version of create_job appeared. I'll perform a regeneration and include update_job and pull in your tests.

@pietern pietern closed this in #541 Aug 18, 2022
wchau pushed a commit to wchau/databricks-cli that referenced this pull request Aug 25, 2022
This is a merge of databricks#457 and a regenerated copy of `service.py`.

Co-authored-by: Ari Angelo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing python sdk functions & arguments (create_job, update_job, etc)

4 participants