Skip to content

fix: resolve conflicting exception guidance in __dlpack__ #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

fix: resolve conflicting exception guidance in __dlpack__ #887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72a21ad
fix: resolve conflicting exception guidance in `__dlpack__`
kgryte Jan 23, 2025
ab33f78
fix: backport changes to 2023.12 revision
kgryte Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/array_api_stubs/_2023_12/array_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ def __dlpack__(
``__dlpack__`` to return a capsule referencing an array whose underlying memory is
accessible to the Python interpreter (represented by the ``kDLCPU`` enumerator in DLPack).
If a copy must be made to enable this support but ``copy`` is set to ``False``, the
function must raise ``ValueError``.
function must raise ``BufferError``.

Other device kinds will be considered for standardization in a future version of this
API standard.
Expand Down
2 changes: 1 addition & 1 deletion src/array_api_stubs/_draft/array_object.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ def __dlpack__(
``__dlpack__`` to return a capsule referencing an array whose underlying memory is
accessible to the Python interpreter (represented by the ``kDLCPU`` enumerator in DLPack).
If a copy must be made to enable this support but ``copy`` is set to ``False``, the
function must raise ``ValueError``.
function must raise ``BufferError``.

Other device kinds will be considered for standardization in a future version of this
API standard.
Expand Down
Loading