Skip to content

Require that data type objects implement __eq__ in order to test for data type equality #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 20, 2021
Merged

Require that data type objects implement __eq__ in order to test for data type equality #273

merged 2 commits into from
Sep 20, 2021

Conversation

kgryte
Copy link
Contributor

@kgryte kgryte commented Sep 20, 2021

This PR

@kgryte kgryte added the API extension Adds new functions or objects to the API. label Sep 20, 2021
@kgryte kgryte requested a review from asmeurer September 20, 2021 18:32
@kgryte
Copy link
Contributor Author

kgryte commented Sep 20, 2021

Thanks for reviewing, @asmeurer!

@kgryte kgryte merged commit 70fcdd7 into main Sep 20, 2021
@kgryte kgryte deleted the dtype-eq branch September 20, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmeurer asmeurer asmeurer approved these changes

Assignees
No one assigned
Labels
API extension Adds new functions or objects to the API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dtype / checking standardization
2 participants
@kgryte @asmeurer