Restructure package, datascience.py -> table.py, and stub map widget#16
Merged
Restructure package, datascience.py -> table.py, and stub map widget#16
Conversation
Before, all the code in this package lived in the `datascience.py` file. In this commit, I add a folder structure to the package to facilitate adding additional functionality. Specifically, I add a `maps` module which will eventually contain the logic to render a GMap widget in a notebook (see #5). The widget will require Javascript to be placed in the user's `nbextension` directory, so I add the relevant code in `setup.py` to do so. After this commit is merged, we are still to type: ```python from datascience import * letters = ['a', 'b', 'c', 'z'] counts = [9, 3, 3, 1] points = [1, 2, 2, 10] t = Table([('letter', letters), ('count', counts), ('points', points)]) print(t) letter | count | points a | 9 | 1 b | 3 | 2 c | 3 | 2 z | 1 | 10 ``` With an eventual API of ```python from datascience import draw_map draw_map(...) ``` Resolves #15
Contributor
|
Great! |
papajohn
added a commit
that referenced
this pull request
Jul 21, 2015
Restructure package, datascience.py -> table.py, and stub map widget
chrispyles
added a commit
to khsu2000/datascience
that referenced
this pull request
Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, all the code in this package lived in the
datascience.pyfile.In this commit, I add a folder structure to the package to facilitate
adding additional functionality. Specifically, I add a
mapsmodulewhich will eventually contain the logic to render a GMap widget in a
notebook (see #5).
The widget will require Javascript to be placed in the user's
nbextensiondirectory, so I add the relevant code insetup.pyto doso.
After this commit is merged, we are still able to type:
With an eventual API of
Resolves #15