fix: remove check for group non unilateral member power

[pauldelucia]

Issue being fixed or feature implemented

The validation for group member powers seemed to be wrong. We were validating that the collective power of a group's non-unilateral members was at least the group's required power. However, this check was unnecessary and prevented certain group configurations, for example a group with 3 members all of whom's powers equal the groups' required power.

What was done?

Remove the check and the error altogether.

How Has This Been Tested?

DET

Breaking Changes

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
• I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

• I have assigned this pull request to a milestone

Summary by CodeRabbit

• Refactor

  • Streamlined the validation process for group configurations by eliminating a redundant power threshold check. Overall power requirements remain enforced, leading to a simpler error reporting flow and enhanced consistency.

• Tests

  • Removed an outdated test case that verified group power thresholds to better align the test suite with the updated validation logic.

• Bug Fixes

  • Removed handling for a specific error related to non-unilateral member power, simplifying error management and potentially impacting how errors are reported in the application.

[coderabbitai]

Walkthrough

This pull request removes the non-unilateral member power validation from the group data contract. The change eliminates the associated error type and its handling across several modules. Adjustments include deleting the check within the validation method, removing the custom error struct, updating the error enum and its error code mapping, and deleting a test that verified this specific condition. Additionally, the conversion for this error in the JavaScript error representation (WASM layer) has been removed.

Changes

File(s)	Change Summary
rs-dpp/.../group/v0/mod.rs, rs-dpp/.../data_contract/group_non_unilateral_member_power_has_less_than_required_power_error.rs, rs-dpp/.../data_contract/mod.rs	Removed the non-unilateral member power check in group validation, deleted the associated error struct, and removed its module export.
rs-dpp/.../errors/consensus/basic/basic_error.rs, rs-dpp/.../errors/consensus/codes.rs	Removed the GroupNonUnilateralMemberPowerHasLessThanRequiredPowerError variant and updated the error code mapping accordingly.
rs-drive-abci/.../data_contract_create/mod.rs	Deleted the test that validated behavior when non-unilateral member power did not reach the required threshold.
wasm-dpp/.../consensus_error.rs	Removed the branch that converted the removed error into its JavaScript error representation.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Validator as GroupV0.validate
    User->>Validator: Call validate()
    Note right of Validator: Non-unilateral power check removed
    Validator->>Validator: Validate total power and individual member limits
    Validator-->>User: Return validation result

Loading

Possibly related PRs

• feat(platform)!: enhance token configuration and validation mechanisms #2439: The changes in the main PR are related to the removal of the GroupNonUnilateralMemberPowerHasLessThanRequiredPowerError, which is also reflected in the retrieved PR where the InvalidGroupPositionError variant is removed from the BasicError enum, indicating a broader cleanup of error handling related to group member validations.
• fix(dpp): decoding invalid consensus error variants #2510: The changes in the main PR, which involve the removal of the GroupNonUnilateralMemberPowerHasLessThanRequiredPowerError, are directly related to the modifications in the retrieved PR that also involve the BasicError enum, as both PRs address the removal of specific error variants from the error handling logic.

Suggested reviewers

• shumkov
• QuantumExplorer

Poem

I hop through code with joyful cheer,
Removing checks that once caused fear,
No error for power not in line,
A smoother path now does align,
With leaps of logic, my code shines! 🐇🥕

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8283e79 and de52a17.

📒 Files selected for processing (1)

• packages/rs-dpp/src/data_contract/group/v0/mod.rs (0 hunks)

💤 Files with no reviewable changes (1)

• packages/rs-dpp/src/data_contract/group/v0/mod.rs

⏰ Context from checks skipped due to timeout of 90000ms (19)

• GitHub Check: Rust packages (dpp) / Tests
• GitHub Check: Rust packages (dpp) / Unused dependencies
• GitHub Check: Rust packages (dpp) / Linting
• GitHub Check: Rust packages (dash-sdk) / Linting
• GitHub Check: Rust packages (drive-abci) / Check each feature
• GitHub Check: Rust packages (dash-sdk) / Formatting
• GitHub Check: Rust packages (dash-sdk) / Check each feature
• GitHub Check: Rust packages (dash-sdk) / Tests
• GitHub Check: Rust packages (dash-sdk) / Unused dependencies
• GitHub Check: Rust packages (drive) / Tests
• GitHub Check: Rust packages (drive-abci) / Linting
• GitHub Check: Rust packages (drive-abci) / Formatting
• GitHub Check: Rust packages (wasm-dpp) / Linting
• GitHub Check: Rust packages (drive) / Linting
• GitHub Check: Rust packages (wasm-dpp) / Tests
• GitHub Check: Build Docker images (Drive, drive, drive-abci) / Build Drive image
• GitHub Check: Build Docker images (DAPI, dapi, dapi) / Build DAPI image
• GitHub Check: Build Docker images (Dashmate helper, dashmate-helper, dashmate-helper) / Build Dashmate helper image
• GitHub Check: Build JS packages / Build JS

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.