Skip to content

Add option --proprietary-codecs to enable non-free codecs #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cztomczak merged 1 commit into from
Oct 3, 2018
Merged

Add option --proprietary-codecs to enable non-free codecs #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tools/automate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
[--use-system-freetype USE_SYSTEM_FREETYPE]
[--use-gtk3 USE_GTK3]
[--use-ccache USE_CCACHE]
[--proprietary-codecs PROPRIETARY_CODECS]
[--no-depot-tools-update NO_DEPOT_TOOLS_UPDATE]
automate.py (-h | --help) [type -h to show full description for options]

Expand Down Expand Up @@ -70,6 +71,8 @@
--use-system-freetype Use system Freetype library on Linux (Issue #402)
--use-gtk3 Link CEF with GTK 3 libraries (Issue #446)
--use-ccache Use ccache for faster (re)builds
--proprietary-codecs Enable proprietary codecs such as H264 and AAC,
licensing restrictions may apply.
--no-depot-tools-update Do not update depot_tools/ directory. When
building old unsupported versions of Chromium
you want to manually checkout an old version
Expand Down Expand Up @@ -119,6 +122,7 @@ class Options(object):
use_system_freetype = False
use_gtk3 = False
use_ccache = False
proprietary_codecs = False
no_depot_tools_update = False

# Internal options
Expand Down Expand Up @@ -913,6 +917,10 @@ def getenv():
if Options.use_ccache:
env["GN_DEFINES"] += " cc_wrapper=ccache"

# Enable proprietary codecs
if Options.proprietary_codecs:
env["GN_DEFINES"] += " proprietary_codecs=true ffmpeg_branding=Chrome"

# To perform an official build set GYP_DEFINES=buildtype=Official.
# This will disable debugging code and enable additional link-time
# optimizations in Release builds.
Expand Down