Make PYTHONPATH update work cross-platform #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`os.path.pathsep` is `:` on POSIX-like platforms and `;` on Windows, so use that when adding paths to the `PYTHONPATH` variable. `os.getenv` does (correct) case-insensitive lookup, but `env` here will be case-sensitive. Read existing value from `os.getenv` instead.
|
Hopefully you've got CI to validate that... oh guess not. I just made the edit quickly in the web editor and haven't tested it |
|
Thanks! Yeah adding CI is on my list of things to do. I will check this before merging. Won't be able to get to this probably until next week (out of town this weekend). |
|
Gave it a quick test and it worked. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.path.pathsepis:on POSIX-like platforms and;on Windows, so use that when adding paths to thePYTHONPATHvariable.os.getenvdoes (correct) case-insensitive lookup, butenvhere will be case-sensitive. Read existing value fromos.getenvinstead.