Skip to content

Comments

Fix bug that causes the useLoader to not re-render#522

Merged
marcospassos merged 1 commit intomasterfrom
fix-loader
Mar 16, 2025
Merged

Fix bug that causes the useLoader to not re-render#522
marcospassos merged 1 commit intomasterfrom
fix-loader

Conversation

@marcospassos
Copy link
Member

Summary

The PR introducing the staleWhileLoading feature caused the useLoader to not re-render in some cases. This PR refactor the hook simplifying the logic and fixing the issue.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@marcospassos marcospassos added the bug Something isn't working label Mar 16, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 16, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@croct/plug-react@522

commit: 5af24f3

@marcospassos marcospassos merged commit e334345 into master Mar 16, 2025
20 checks passed
@marcospassos marcospassos deleted the fix-loader branch March 16, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant