Skip to content

Update 'SDL2' package to v2.0.18 #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbsheth merged 1 commit into from
Dec 20, 2021
Merged

Update 'SDL2' package to v2.0.18 #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/configs/default.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ hunter_default_version(Qwt VERSION 6.1-p3)
hunter_default_version(RapidJSON VERSION 1.1.0-b557259-p0)
hunter_default_version(RapidXML VERSION 1.13)
hunter_default_version(RedisClient VERSION 0.6.1-p1)
hunter_default_version(SDL2 VERSION 2.0.16-p0)
hunter_default_version(SDL2 VERSION 2.0.18)
hunter_default_version(SDL_image VERSION 2.0.5-p0)
hunter_default_version(SDL_mixer VERSION 2.0.4-p0)
hunter_default_version(SDL_net VERSION 2.0.1-p0)
Expand Down
11 changes: 11 additions & 0 deletions cmake/projects/SDL2/hunter.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,17 @@ hunter_add_version(
3b8d0dfdbd1b062035a9432bff75a22ab439bcd1
)

hunter_add_version(
PACKAGE_NAME
SDL2
VERSION
"2.0.18"
URL
"https://github.com/libsdl-org/SDL/archive/release-2.0.18.tar.gz"
Copy link

@NeroBurner NeroBurner Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDL can now be used directly from upstream? I doubt SDL has no external dependencies for building. Or did they themself add Hunter support?

Copy link
Member Author

@drodin drodin Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It has no external dependencies. 2.0.12 only needed an alias for static lib (SDL2::SDL2 to SDL2::SDL2-static, for hunter backward compatibility), same as 2.0.16 (2.0.14 cmake was broken a lot, so I didn't bother). They finally put the exact same alias in SDL2Config.cmake in 2.0.18, so at least this version can be used from upstream.

Copy link

@NeroBurner NeroBurner Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome! Thank you!

SHA1
b765ac6a7bfc617ce51ff2571b1ae056357413f2
)

hunter_add_version(
PACKAGE_NAME
SDL2
Expand Down