Conversation
|
@craffael I don't know what we should do to test this package. Thoughts? |
|
(without bumping the CMake version in CI, necessarily) |
|
Sorry for taking such a long time. Regarding the problem with the CMake version, I think the optimal solution would be if individual packages can specify another cmake version to use for ci. But this would require a few changes on the polly repository and the one over here. If you want I can make PR's? |
|
Alternatively you could also just let the ci fail for tcmalloc... I guess there are not so many packages which require such a recent version of cmake... |
No problem, I've been pretty slow these days too... Sure, let's do that and I can review. |
|
any updates on this? |
NeroBurner
left a comment
There was a problem hiding this comment.
updating PR to require CMake 3.10
|
all CI checks fail. In GCC-13 there is an ABSL bug. Closing PR, please reopen if you're still around and want to work on this again. Sorry for the long wait |
step by step carefully. Yes
Note that currently all ci-jobs fail because the tcmalloc needs cmake 3.21 or higher. Maybe it would be an option to bump cmake version in polly's
install-ci-dependencies.py...?