Update spdlog to 1.4.2-p2, fixing missing cassert include

[dan-42]

• I've followed this guide
  step by step carefully. [Yes]

• I've tested this package remotely and have excluded all broken builds.
  Here is the links to the Travis/AppVeyor with status "All passed":

  • https://ci.appveyor.com/project/dan-42/hunter/builds/29827625
  • https://travis-ci.org/dan-42/hunter/builds/631261840

the -p2 means that I use the latest changes from spdlogs branch v1.x which includes a fix when compiling on gcc9.2 which misses an #include

Please delete the following branch hunter-1.4.2-p1 from the repo https://github.com/cpp-pm/spdlog as I created it accidently from spdlog's master-branch which is wrong.
And I do not have the privileges to delete a protected branch.

PING: @bkotzz @rbsheth

[dan-42]

All tool-chains that are also run on the 1.4.2-p0 release work. I just did not disable them.
See:
https://ci.appveyor.com/project/ingenue/hunter/builds/28559512\
https://travis-ci.org/ingenue/hunter/builds/606261633?utm_medium=notification

But If you insist, I will update the list of tool-chains, and update the PR.

@bkotzz @rbsheth

[mileschao]

@dan-42 @bkotzz @rbsheth why this PR's merge is blocked?

[bkotzz]

I’m a bit confused. You mention 1.4.2-p0, but I don’t see that branch or tag anywhere? And then -p1 was a mistake, and -p2 is the new release? Did this ever go through code review?

[dan-42]

I’m a bit confused. You mention 1.4.2-p0, but I don’t see that branch or tag anywhere? And then -p1 was a mistake, and -p2 is the new release? Did this ever go through code review?

• 1.4.2-p0 is still on the https://github.com/hunter-packages/spdlog/branches sorry should have said that and it is not callled -p0

• 1.4.2-p1 was a mistake, yes

• 1.4.2-p2 is the latest release, or take from the repos v1.x branch. spdlog is a bit slow in creating releases, but adds continuously bugfixes and features to it.

[rbsheth]

This updating of spdlog's v1.x branch is confusing. Let's use the convention of last known release version + git hash for the updated version in Hunter. I created the new branch and release for you here: https://github.com/cpp-pm/spdlog/releases/tag/v1.4.2-58e6890-p0 and deleted the other, confusing branches.

For new versions, the branch name should be hunter-<version> without the p0. The release+tag adds the p0, p1, p2, etc. so that you can continue patching the same branch but have multiple releases.

[dan-42]

you are right, that is much better. Thank you for removing the wrong branches and creating a new one.

I'll update the PR as soon as I find the time for it.

[dan-42]

Building:

• https://ci.appveyor.com/project/dan-42/hunter/builds/29955847
• https://travis-ci.org/dan-42/hunter/builds/633928283

[rbsheth]

@dan-42 Thanks for updating the PR. Looks like some toolchains failed that weren't before? Can you check them please?

[dan-42]

@rbsheth You're welcome.

The toolchains that fail, had been disabled in the last release (1.4.2-p0), see my second comment above.

But if you insist I will also disable them just to have passing tests :-)

[rbsheth]

@dan-42 Yes, please disable them. :)

[dan-42]

@rbsheth

Here are the successful builds:

• https://ci.appveyor.com/project/dan-42/hunter/builds/29992535
• https://travis-ci.org/dan-42/hunter

Now shall I provide a PR to https://github.com/cpp-pm/hunter-testing/tree/pkg.spdlog
with my changes?
I think the documentation is not very clear here for me.

[rbsheth]

Yup, a PR to hunter-testing after pkg.template is updated works.

[rbsheth]

Released: https://github.com/cpp-pm/hunter/releases/tag/v0.23.242

[rbsheth]

Branch pkg.template has been updated https://github.com/cpp-pm/hunter-testing

[dan-42]

PR for hunter-testing: cpp-pm/hunter-testing#32