-
Notifications
You must be signed in to change notification settings - Fork 161
geth update to 1.9.24 #594
Conversation
x/evm/types/statedb.go
Outdated
| } | ||
|
|
||
| // AddAddressToAccessList is currently unimplemented | ||
| func (csdb *CommitStateDB) AddAddressToAccessList(_ ethcmn.Address) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add this functionality since it is used for supporting EIP2929. I think there are additional journal entries too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I'll work on implementing it
fedekunze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iterating over maps causes non-determinism on the app. Let's use slices instead
fedekunze
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)