Volatile config warnings #1624
Open
Volatile config warnings #1624
+1,119
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add default threshold of 30 days for volatile config expiration warnings. This value can be overridden via ruleData in policy configuration. Used by the upcoming volatile_config policy rules.
New library at policy/lib/volatile_config.rego provides: - warning_threshold_days: configurable threshold from rule_data (default 30) - days_until_expiration(rule): calculate days until effectiveUntil - is_rule_applicable(rule, image_ref, digest, component): check if rule applies to current image via imageDigest, imageRef (deprecated), imageUrl prefix, or componentNames - warning_category(rule): returns one of: - "invalid": unparseable dates - "pending": effectiveOn in future - "expired": effectiveUntil in past - "expiring": effectiveUntil within warning threshold - "no_expiration": active rule with no effectiveUntil Comprehensive tests with 100% coverage.
New policy package at policy/release/volatile_config generates warnings for volatile configuration rules that have lifecycle events: - pending_rule: effectiveOn date is in the future - expiring_rule: effectiveUntil within warning threshold (default 30 days) - no_expiration: active rule with no effectiveUntil date set - expired_rule: effectiveUntil date has passed - invalid_config: date values cannot be parsed as RFC 3339 Warnings are only generated for rules applicable to the current image based on imageDigest, imageRef (deprecated), imageUrl prefix, or componentNames scoping. All rules are included in 'minimal' and 'redhat' collections. Comprehensive tests with 100% coverage.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Rego policy rules that generate warnings for volatile configuration rules with lifecycle events requiring attention. Volatile config rules (volatileConfig.include / volatileConfig.exclude) allow temporary exceptions to policy rules with time-based constraints, and these warnings help users proactively manage them.
https://issues.redhat.com/browse/EC-1616
This depends on conforma/cli#3077