Skip to content

refactor(Init): fix unbounded variable in _ask_tag_format #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v4-9-0-test
Choose a base branch
from

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented Jun 10, 2025

Description

Before this change, the type of tag_format is Any | Unbounded | str at the end of the function. Actually tag_format is defined for all code paths.

  • If is_correct_format is True, then tag_format is assigned "v$version" and the function returns it.
  • If is_correct_format is False, then tag_format is initialized in the if-block.

The function logic should be easier to understand after this change.

Checklist

Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v4-9-0-test@6b4f8b0). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             v4-9-0-test    #1529   +/-   ##
==============================================
  Coverage               ?   98.07%           
==============================================
  Files                  ?       58           
  Lines                  ?     2700           
  Branches               ?        0           
==============================================
  Hits                   ?     2648           
  Misses                 ?       52           
  Partials               ?        0           
Flag Coverage Δ
unittests 98.07% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Lee-W Lee-W added this to the 4.9.0 milestone Jun 10, 2025
@bearomorphism bearomorphism marked this pull request as ready for review June 10, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants