-
-
Notifications
You must be signed in to change notification settings - Fork 287
build(.gitignore): ignore pyrightconfig.json
and poetry.toml
#1483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refactors
Are you sure you want to change the base?
Conversation
Since the project requires Python >=3.9, argparse only raises SystemExit when non-existent commands are provided, making TypeError handling unnecessary.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1483 +/- ##
==========================================
Coverage 97.82% 97.82%
==========================================
Files 57 57
Lines 2619 2619
==========================================
Hits 2562 2562
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
||
### Python Patch ### | ||
# Poetry local configuration file - https://python-poetry.org/docs/configuration/#local-configuration | ||
poetry.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm kinda curious what the behavior you decide but we shouldn't add it to commitizen
@@ -113,3 +113,10 @@ venv.bak/ | |||
|
|||
# ruff | |||
.ruff_cache | |||
|
|||
# LSP config files | |||
pyrightconfig.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding it to your ~/.gitignore
instead. I don't like to add things to ignore that's not directly related to commitizen (yep ".vscode" is kinda not my taste either)
Description
I referred to the
.gitignore
template from this webpage and suggest adding two items to be ignored:pyrightconfig.json
– For users who use VS Code, they might have their own preferred configurations forpyright/pylance
.poetry.toml
– This repository uses Poetry to manage packages. This file can be used to configure some Poetry-related environment variables for the project, such as creating the virtual environment inside the project directory instead of under the .cache folder in the home directory.Checklist
Code Changes
poetry all
locally to ensure this change passes linter check and testsDocumentation Changes
poetry doc
locally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context