refactor: do not guess if changelog format is provided, make function private #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## refactors #1471 +/- ##
==========================================
Coverage 97.82% 97.82%
==========================================
Files 57 57
Lines 2619 2620 +1
==========================================
+ Hits 2562 2563 +1
Misses 57 57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lee-W
reviewed
May 31, 2025
|
|
||
| if not format: | ||
| raise ChangelogFormatUnknown(f"Unknown changelog format '{name}'") | ||
|
|
||
| return format(config) | ||
|
|
||
|
|
||
| def guess_changelog_format(filename: str | None) -> type[ChangelogFormat] | None: | ||
| def _guess_changelog_format(filename: str | None) -> type[ChangelogFormat] | None: |
There was a problem hiding this comment.
We probably could add a deprecation warning to guess_changelog_format and remove it in v5
There was a problem hiding this comment.
fixed, please review
| @@ -6,14 +6,12 @@ | |||
|
|
|||
| def committer_factory(config: BaseConfig) -> BaseCommitizen: | |||
| """Return the correct commitizen existing in the registry.""" | |||
| name: str = config.settings["name"] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and testsDocumentation Changes
poetry doclocally to ensure the documentation pages renders correctlyExpected Behavior
Steps to Test This Pull Request
Additional Context