QUA-958: Push images to Dockerhub instead of GCR #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camillof
reviewed
Feb 16, 2023
| @@ -37,13 +37,13 @@ RUN composer install --no-dev && \ | |||
|
|
|||
| # Build Content | |||
| COPY bin/build-content ./bin/build-content | |||
| RUN apk add --no-cache ruby ruby-json ruby-bigdecimal ruby-dev build-base libxml2-dev libxslt-dev libffi-dev && \ | |||
| RUN apk add --no-cache ruby ruby-json ruby-bigdecimal ruby-dev build-base libxml2-dev libxslt-dev libffi-dev yaml-dev && \ | |||
There was a problem hiding this comment.
Hey, it looks good to me, before approving it, do you mind explaining why we need this yaml-dev library please?
There was a problem hiding this comment.
to install rdoc which is included in a previous step in the Dockerfile, it needs this yaml-dev library to install correctly. If we don't include this library, this error pops up in the installation:
this didn't happen before because with the alpine:edge image, we were sitting on version 3.15.0_alpha20210804 instead of version 3.15.0, which might not have that necessary yaml-dev library.
camillof
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate pushing of the image to GCR in favor of pushing to Dockerhub.
Also, replace base image from
alpine:edgetoalpine:3.15.0to prevent CI failure