Skip to content

Conversation

chrishulton
Copy link
Contributor

@chrishulton chrishulton commented May 9, 2017

Addresses error:

PHP Fatal error:  Uncaught TypeError: Argument 1 passed to 
  PHPMD\PHPMD::setFileExtensions() must be of the type array, null given

Our docs are inconsistent about how to specify this setting, ie:

engines:
  phpmd:
    enabled: true
    config:
      file_extensions: "php"

vs

engines:
  phpmd:
    enabled: true
    config:
      file_extensions: 
        - php
        - inc

We could just update the docs, but it is easy enough to support both. I did not add a spec for this, but I tested it out with a local repo.

In order to make this change, I had to update the Dockerfile to get the image building. I also decided to update the dependencies while in here, which required a fix to the Makefile.

@chrishulton chrishulton force-pushed the chris/does-this-build branch from f9d8821 to b09a601 Compare May 9, 2017 21:10
@chrishulton chrishulton requested a review from maxjacobson May 9, 2017 21:25
Copy link
Contributor

@maxjacobson maxjacobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great branch name 😄

Seems like this build breaks fairly easily... I had to make some fixes recently to get the build going again then... hm.

This fix LGTM though. If we have support for proper arrays, that's way better than CSV-style lists.

@chrishulton chrishulton merged commit 403a58e into master May 9, 2017
@chrishulton chrishulton deleted the chris/does-this-build branch May 9, 2017 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants