Fix unescaped unicode encoding parameter #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3rd parameter for json_encode is a max depth limitation. JSON_UNESCAPED_UNICODE has an int value of 256 whereas the max depth value is 512 (so no matter this way). This patch restores the expected usage of UNESCAPED_UNICODE param which is to encode multibyte Unicode characters literally.
L116
``` } catch (Exception $e) { // can't be catched because CodeClimate\PHPMD\Exception does not exist```
Another way to fix this is:
``` } catch (\Exception $e) {```
|
Sorry, I did not want to pull this 2 patches into one. I'll close and reopen 2 separated pulls in a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3rd parameter for json_encode is a max depth limitation.
JSON_UNESCAPED_UNICODEhas an int value of 256 whereas the max depth value is 512 (so no matter this way). This patch restores the expected usage of UNESCAPED_UNICODE param which is toencode multibyte Unicode characters literally.