Bump csslint #23
Bump csslint #23
Conversation
This commit fixes the checkstyle-xml formatter to include an identifier attribute on all errors. File read errors were previously missed and caused a NoMethodError in the engine when an identifier attribute was used on these errors. The commit sha was also extracted to a variable in the Dockerfile and added as a full commit sha. This makes for easier editing (git log or the GitHub UI most often gives you full shas) and should keep the diff clearer that only the sha was changed.
|
This is minor, the csslint change itself was LGTMd, and I verified locally that this fixes the motivating customer build. Merging. |
|
Hi @pbrisbin This was just causing a build failure to us too, pulled the b5 image from docker, and seems it fixed it, is this already available within your hosted engines platform ? |
|
@joiggama just a few more steps to get it deployed. I can ping you back here when it's out. Sorry for the bug :( |
|
@pbrisbin Thanks, no worries, I appreciate the effort, keep up the great work 👍 |
|
Oh, and also: we reverted the bad version this morning at 11:09 anyway, so you shouldn't be seeing errors right now on Platform. |
|
@pbrisbin Oh, thanks, I might just trigger a new build then. |
|
Just following up here: this fix is out on Platform now. Again, sorry for the trouble. |
|
No worries, thank you @pbrisbin. The previous build worked as you pointed out the reverted version. |
This commit fixes the checkstyle-xml formatter to include an identifier
attribute on all errors. File read errors were previously missed and caused a
NoMethodError in the engine when an identifier attribute was used on these
errors.
The commit sha was also extracted to a variable in the Dockerfile and added as
a full commit sha. This makes for easier editing (git log or the GitHub UI most
often gives you full shas) and should keep the diff clearer that only the sha
was changed.
/cc @codeclimate/review
I left the "compare link" out of this commit because it would just be a link to
that commit which is information already present in the diff itself.