Skip to content

Add env config for buy module flag #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions pkg/code/server/grpc/user/config.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
package user

import (
"github.com/code-payments/code-server/pkg/config"
"github.com/code-payments/code-server/pkg/config/env"
"github.com/code-payments/code-server/pkg/config/memory"
"github.com/code-payments/code-server/pkg/config/wrapper"
)

const (
envConfigPrefix = "USER_SERVICE_"

EnableBuyModuleConfigEnvName = envConfigPrefix + "ENABLE_BUY_MODULE"
defaultEnableBuyModule = true
)

type conf struct {
enableBuyModule config.Bool
}

// ConfigProvider defines how config values are pulled
type ConfigProvider func() *conf

// WithEnvConfigs returns configuration pulled from environment variables
func WithEnvConfigs() ConfigProvider {
return func() *conf {
return &conf{
enableBuyModule: env.NewBoolConfig(EnableBuyModuleConfigEnvName, defaultEnableBuyModule),
}
}
}

type testOverrides struct {
}

func withManualTestOverrides(overrides *testOverrides) ConfigProvider {
return func() *conf {
return &conf{
enableBuyModule: wrapper.NewBoolConfig(memory.NewConfig(defaultEnableBuyModule), defaultEnableBuyModule),
}
}
}
5 changes: 4 additions & 1 deletion pkg/code/server/grpc/user/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import (

type identityServer struct {
log *logrus.Entry
conf *conf
data code_data.Provider
auth *auth_util.RPCSignatureVerifier
limiter *limiter
Expand All @@ -60,6 +61,7 @@ func NewIdentityServer(
auth *auth_util.RPCSignatureVerifier,
antispamGuard *antispam.Guard,
messagingClient messaging.InternalMessageClient,
configProvider ConfigProvider,
) userpb.IdentityServer {
// todo: don't use a local rate limiter, but it's good enough for now
// todo: these rate limits are arbitrary and might need tuning
Expand All @@ -69,6 +71,7 @@ func NewIdentityServer(

return &identityServer{
log: logrus.StandardLogger().WithField("type", "user/server"),
conf: configProvider(),
data: data,
auth: auth,
limiter: limiter,
Expand Down Expand Up @@ -398,7 +401,7 @@ func (s *identityServer) GetUser(ctx context.Context, req *userpb.GetUserRequest
},
EnableInternalFlags: isStaff,
EligibleAirdrops: eligibleAirdrops,
EnableBuyModule: true,
EnableBuyModule: s.conf.enableBuyModule.Get(ctx),
}, nil
}

Expand Down
1 change: 1 addition & 0 deletions pkg/code/server/grpc/user/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ func setup(t *testing.T) (env testEnv, cleanup func()) {
auth.NewRPCSignatureVerifier(env.data),
antispamGuard,
messaging.NewMessagingClient(env.data),
withManualTestOverrides(&testOverrides{}),
)
env.server = s.(*identityServer)
env.server.domainVerifier = mockDomainVerifier
Expand Down
Loading