systemd: Use binary channel for Terminal #20840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 1b15dcb did not cover a "completely" binary channel with no UTF-8 data at all. Also try to read that binary http endpoint as text channel and ensure the channel gets closed properly with `protocol-error`.
Unlike most other code paths, raising a ChannelError in data_received() did not get translated to a proper close message. In particular, this caused an unhandled bridge exception in __decode_frame() when a text channel encountered non-UTF8 data since commit 1b15dcb. Side issue in cockpit-project#20791
Terminals are not defined/required to be UTF-8 only. Sometimes people cat binary data to the terminal, or possibly files in other encodings. These cannot be sent through `TEXT` websocket channels, and will also trigger the additional checks from commit 1b15dcb. Use a binary channel to avoid all that. XTerm.js gets along with this just fine, and it ignores invalid data. With this you can now even `cat /bin/true` and get something moderately sensible, instead of no output at all. Fixes cockpit-project#20791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminals are not defined/required to be UTF-8 only. Sometimes people
cat binary data to the terminal, or possibly files in other encodings.
These cannot be sent through
TEXTwebsocket channels, and will alsotrigger the additional checks from commit 1b15dcb.
Use a binary channel to avoid all that. XTerm.js gets along with this
just fine, and it ignores invalid data.
With this you can now even
cat /bin/trueand get something moderatelysensible, instead of no output at all.
Fixes #20791