-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: Expose Stratis virtual filesystem sizes #20611
Conversation
b53295d
to
bc92edf
Compare
a62d313
to
19e362f
Compare
8db80eb
to
4204c65
Compare
4204c65
to
94bc33b
Compare
Let's get this in. The UI here assumes that people are experts in Stratis and know exactly what they are doing and don't need any help or explanations from Cockpit. If that's not good enough, then we have to kill this. I am not going to work on this much more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong argument against or for. There is one tiny codeql
warning however which seems nice to fix.
Yeah, it's meh all around.
There's lots of linting to be done, but I think the |
Ohh: there were two "unused |
94bc33b
to
b6a0bc9
Compare
Instead of the "Managed filesystem sizes" concept. This makes Cockpit easier to discover when you know the real Stratis concepts and exposes its full capabilities.
b6a0bc9
to
e3afc88
Compare
visible: vals => vals.size_options.custom_limit, | ||
value: fsys.SizeLimit[0] && Number(fsys.SizeLimit[1]), | ||
min: Number(fsys.Size), | ||
max: pool.Overprovisioning ? stats.pool_total : stats.pool_free + Number(fsys.Size), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This added line is not executed by any test.
Followup fixups mentioned @ #21039 (comment) with mockups. (See the bottom mockup at comment #21039 (comment) for fully revised strings.) |
Instead of the "Managed filesystem sizes" concept. This makes Cockpit
easier to discover when you know the real Stratis concepts and exposes
its full capabilities.
Demo: https://youtu.be/E1zqhAowus8
Longer exploration: https://youtu.be/1W6QPNPwT7Q
Storage: Support for managing virtual Stratis filesystem sizes
Cockpit now directly exposes the
--size
and--size-limit
options of thestratis filesystem create
command as well as thestratis filesystem set-size-limit
andstratis filesystem unset-size-limit
commands.