Conversation
osterman
reviewed
Jul 18, 2018
Makefile
Outdated
| rm -rf utterances | ||
| git clone --branch master https://github.com/cloudposse/utterances.git | ||
| cd utterances && yarn && yarn build | ||
| mkdir -p public/utterances |
Member
There was a problem hiding this comment.
I don't think you want this mkdir here since below you're moving (renaming) one directory to this name.
osterman
reviewed
Jul 18, 2018
Makefile
Outdated
| ## Build customized utterances widget | ||
| utterances/build: | ||
| rm -rf utterances | ||
| git clone --branch master https://github.com/cloudposse/utterances.git |
osterman
reviewed
Jul 18, 2018
Makefile
Outdated
| ## Build customized utterances widget | ||
| utterances/build: | ||
| rm -rf utterances | ||
| git clone --branch master https://github.com/cloudposse/utterances.git |
Member
There was a problem hiding this comment.
Hrmm... this is shaddowing the utterances submodule
osterman
reviewed
Jul 18, 2018
| rm -rf utterances | ||
|
|
||
| ## Build front-end components | ||
| components/build: utterances/build |
Member
There was a problem hiding this comment.
add an @exit 0 below the target name
osterman
reviewed
Jul 23, 2018
Makefile
Outdated
| mv utterances/dist/*.svg public/assets | ||
| mkdir -p public/utterances/ | ||
| mv utterances/dist/utterances.html public/utterances/index.html | ||
| mkdir -p static/js/utterances static/css/utterances static/assets/utterances |
Member
There was a problem hiding this comment.
We don't have to be so strict about adhering to static/js, static/css, etc when it relates to utterances. I would be okay with just deploying it all to static/utterances since it's a self-contained app
osterman
reviewed
Jul 23, 2018
| <div class="utterances-wrapper"> | ||
| <script src="/js/utterances/client.js" | ||
| repo="docs/docs" | ||
| repo="alebabai/docs" |
Contributor
Author
There was a problem hiding this comment.
yeap, my debug stuff - removed it already)
* use /static/components/* to store all things
Contributor
Author
|
Require cloudposse-archives/utterances#1 to be merged |
osterman
approved these changes
Jul 24, 2018
Closed
goruha
added a commit
that referenced
this pull request
Jul 25, 2018
…faq-rotate-ssh-k8s * 'faq-rotate-ssh-k8s' of github.com:cloudposse/docs: Utterances - Use Customized Fork (#180)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
why
#16