Managed search box on inner pages. #142

[finnsky]

what

• Added inner pages search. Basic theming and functional css.
• Added some global fixes in header.

references

• Enable Search on all Pages #142

[osterman]

Thanks! here are a few issues:

1) search results should slide down from search box and flow over the nav bar

2) height of nav bar changed considerably

Bad

Good

3) Rendering on the homepage shows a thin black strip (the shadow box).

I cannot screenshot it because it goes away too quickly, but it doesn't happen on the live site. It's not a pretty page rendering.

4) The search results do not expand over/on-top-of the white area.

I discovered a bug after we merged the latest CSS changes. They expand the header section. This was previously working.

Bad

Good

4) remove borders from input box

They appear after I click the [X].

Bad

Good

5) rendering jumps around

When I click around, the margin/padding above the breadcrumbs seems to be calculated after page load. This changes the feel of the site as loading new pages is not "smooth". This is not happening on live site.

[osterman]

This is a good start! There are some UI/CSS issues that I'd like to address before we merge. Also, the search results on the homepage no longer expand over the content, instead they expand the dark gray header.

[finnsky]

Please take a look. I moved slack between breadcrumbs and search. But we need to disquss it.
https://gyazo.com/9dc64caefb208b6aaa250d9bc6b86883

[osterman]

Thanks @finnsky! Still see some of the same issues. (I did not git pull)

[osterman]

Looks perfect. Just one nitpick. Searchbox font size should inherit from subnav (13px)

[osterman]

Can you put the badge like this? Doesn't have to be pixel perfect to this example. We can hide the slack badge on smaller screens.

or maybe

[osterman]

• Fix font-size in subnav search box.
• Change position of slack badge.

Then good to go.