Skip to content

Conversation

@JRJurman
Copy link

Summary

Often when injecting the value for a property it may resolve as undefined or null. These more often than not can be treated as not being assigned, however the current implementation sets them to the string value "undefined" or "null".

This PR introduces a change to ignore arguments which would evaluate to null or undefined.
Look at the updated tests to see the full scope of this change.

@JRJurman
Copy link
Author

Looking over the PRs, it appears this is a different implementation of #57
Not sure which is better or why the previous PR has yet to be merged...

@goto-bus-stop
Copy link
Member

cherry-picked your additional tests into #57, thanks! unfortunately the squash-merge removed your credit from the commit log, sorry about that :/ i did add you to the gh release notes instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants