Treatment service Poller#87
Merged
deadlycoconuts merged 20 commits intocaraml-dev:mainfrom Jan 2, 2025
Merged
Conversation
…poller Merging changes for [MM3 2915] Treatment service Poller
deadlycoconuts
requested changes
Jan 2, 2025
Collaborator
deadlycoconuts
left a comment
There was a problem hiding this comment.
Thanks a lot of this PR! There are just a couple of small comments I left, especially on the polling logic which I didn't really understand why it needed to be implemented as such.
deadlycoconuts
approved these changes
Jan 2, 2025
Collaborator
deadlycoconuts
left a comment
There was a problem hiding this comment.
Thanks a lot for all the changes! I've just one last tiny comment but feel free to merge this once that's addressed! :D 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The intention of this PR is to provide the option of utilising a poller in the treatment service instead of pub/sub. The poller will be responsible for pulling the changes periodically instead of subscribing to the management service topic.
Poller can be enabled from treatment service config
Which issue(s) this PR fixes:
Treatment service can be used in cloud environments where pub/sub is currently not supported e.g. Tencent cloud.