fix(ui): Fix segmenter yup validation schema#83
Merged
deadlycoconuts merged 1 commit intocaraml-dev:mainfrom Aug 8, 2024
Merged
fix(ui): Fix segmenter yup validation schema#83deadlycoconuts merged 1 commit intocaraml-dev:mainfrom
deadlycoconuts merged 1 commit intocaraml-dev:mainfrom
Conversation
tiopramayudi
approved these changes
Aug 8, 2024
Collaborator
tiopramayudi
left a comment
There was a problem hiding this comment.
LGTM! Thanks @deadlycoconuts
Collaborator
Author
|
Thanks for the quick review @tiopramayudi, I'll merge this after rebasing this branch once the other PR with the CICD fixes is merged! |
c11d725 to
75e0335
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces an additional fix to the yup validation schema, as a follow up from #80. In particular, the fix in this PR addresses this change:
When using the same
Schema.whenfunction but passing a function directly as an argument instead of the builder object, the signature of the expected function has also been updated from(value, schema)=> Schema): Schemato(values: any[], schema) => Schema): Schema.Existing schemas that do not follow this convention now have been updated to reflect the new expected array:
Example:
Which issue(s) this PR fixes:
Fixes #