Conversation
krithika369
commented
Jun 14, 2023
added 2 commits
June 14, 2023 09:04
deadlycoconuts
approved these changes
Jun 14, 2023
Collaborator
deadlycoconuts
left a comment
There was a problem hiding this comment.
LGTM! 🚀 Thanks for the changes!
Collaborator
|
Just curious, was it intentional to no longer create branches on one's fork for PRs? 😅 |
Collaborator
Author
Since this isn't the practice in Merlin and MLP repos, I decided to just stick to branches for everything (in my new laptop). But I realised that for Turing and XP, the fork's CI steps are cleaner. Will get back to using them for the newer PRs. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR largely replicates the changes for the API in caraml-dev/mlp#87, to have the option of caching authz responses in the XP Management service. As a part of this implementation, the API dependency on MLP has been upgraded.