Skip to content

feat: enable wasm by default#488

Merged
mdjastrzebski merged 7 commits intov1from
feat/enable-wasm-by-default
May 15, 2024
Merged

feat: enable wasm by default#488
mdjastrzebski merged 7 commits intov1from
feat/enable-wasm-by-default

Conversation

@mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented May 14, 2024 •
edited
Loading

Summary

Enable WASM & baseline compilers by default.

Test plan

@changeset-bot
Copy link

changeset-bot bot commented May 14, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 15ae972

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mdjastrzebski mdjastrzebski changed the base branch from main to v1 May 14, 2024 18:10
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited
Loading

Performance Comparison Report

  • Current: HEAD (fd4b833) - 2024-05-15 09:36:25Z
  • Baseline: main (5708d67) - 2024-05-15 09:35:05Z

Significant Changes To Duration

Name Type Duration Count
fib 30 function 82.2 ms → 38.5 ms (-43.8 ms, -53.2%) 🟢🟢 1 → 1
Other Component 10 legacy scenario render 113.6 ms → 68.7 ms (-44.9 ms, -39.5%) 🟢🟢 4 → 4
Other Component 20 render 114.5 ms → 68.8 ms (-45.8 ms, -40.0%) 🟢🟢 4 → 4
Other Component 10 render 114.9 ms → 67.8 ms (-47.1 ms, -41.0%) 🟢🟢 4 → 4
fib 31 function 145.2 ms → 62.8 ms (-82.3 ms, -56.7%) 🟢🟢 1 → 1
Async Component render 190.5 ms → 107.6 ms (-82.9 ms, -43.5%) 🟢🟢 7 → 7
fib 32 function 225.0 ms → 101.2 ms (-123.7 ms, -55.0%) 🟢🟢 1 → 1
Show details
Name Type Duration Count
fib 30 function Baseline
Mean: 82.2 ms
Stdev: 1.9 ms (2.3%)
Runs: 87.3 83.1 81.7 81.6 81.5 81.5 81.4 81.4 81.4 81.3

Current
Mean: 38.5 ms
Stdev: 0.8 ms (2.0%)
Runs: 38.7 38.8 38.6 38.7 38.8 38.8 38.7 38.8 38.3 36.3		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Other Component 10 legacy scenario render Baseline
Mean: 113.6 ms
Stdev: 4.4 ms (3.9%)
Runs: 124 116 115 114 114 113 112 110 110 108

Current
Mean: 68.7 ms
Stdev: 5.3 ms (7.7%)
Runs: 70 66 73 67 64 73 74 60 64 76		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
Other Component 20 render Baseline
Mean: 114.5 ms
Stdev: 5.2 ms (4.5%)
Runs: 128 123 120 120 120 115 115 114 114 112 112 112 112 112 112 111 111 110 110 107

Current
Mean: 68.8 ms
Stdev: 2.8 ms (4.1%)
Runs: 66 67 72 71 68 68 70 68 70 71 71 66 65 68 72 61 71 72 70 68		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4 4
Other Component 10 render Baseline
Mean: 114.9 ms
Stdev: 5.4 ms (4.7%)
Runs: 124 122 116 116 114 114 113 113 113 104

Current
Mean: 67.8 ms
Stdev: 4.7 ms (6.9%)
Runs: 70 73 70 65 66 61 71 62 65 75		 Baseline
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4

Current
Mean: 4
Stdev: 0 (0.0%)
Runs: 4 4 4 4 4 4 4 4 4 4
fib 31 function Baseline
Mean: 145.2 ms
Stdev: 1.8 ms (1.3%)
Runs: 149.4 147.1 146.3 144.7 144.2 144.1 144.1 144.0 144.0 143.9

Current
Mean: 62.8 ms
Stdev: 0.2 ms (0.3%)
Runs: 62.8 62.8 62.7 62.7 62.8 62.8 62.8 62.8 62.8 63.3		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1
Async Component render Baseline
Mean: 190.5 ms
Stdev: 4.6 ms (2.4%)
Runs: 197 196 195 193 192 188 188 186 185 185

Current
Mean: 107.6 ms
Stdev: 6.6 ms (6.1%)
Runs: 114 106 103 100 108 104 106 111 102 122		 Baseline
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7

Current
Mean: 7
Stdev: 0 (0.0%)
Runs: 7 7 7 7 7 7 7 7 7 7
fib 32 function Baseline
Mean: 225.0 ms
Stdev: 2.1 ms (0.9%)
Runs: 229.5 226.0 225.6 225.6 225.2 225.2 224.2 223.3 223.0 222.0

Current
Mean: 101.2 ms
Stdev: 0.2 ms (0.2%)
Runs: 101.0 101.0 101.0 101.0 101.3 101.4 101.3 101.3 101.6 101.4		 Baseline
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Current
Mean: 1
Stdev: 0 (0.0%)
Runs: 1 1 1 1 1 1 1 1 1 1

Meaningless Changes To Duration

There are no entries

Changes To Count

There are no entries

Added Scenarios

There are no entries

Removed Scenarios

There are no entries

Generated by 🚫 dangerJS against 15ae972

@mdjastrzebski mdjastrzebski merged commit 97748f8 into v1 May 15, 2024
@mdjastrzebski mdjastrzebski deleted the feat/enable-wasm-by-default branch May 15, 2024 09:38
mdjastrzebski added a commit that referenced this pull request Jun 16, 2024
@mdjastrzebski @guvenkaranfil
v1 (#456)
ebcf9d6 
* refactor: rename `meassurePerformance` to `measureRenders` (#433)

* chore: v1.0.0-beta

* docs: update changelogs

* docs: migration guide

* chore: update snapshots

* chore: update node ver on GH

* chore: v1.0.0-rc

* chore: v1.0.0-rc.1

* chore: reorganize repo deps (#477)

* refactor: migrate deps

* chore: dedup eslint

* chore: fix eslint deps

* chore: yarn berry (#478)

* chore: yarn berry (wip)

chore: forward reassure cli in the main package

chore: remove --force

chore: fix ci

chore: fix ci

chore: fix typecheck

chore: fix danger

chore: fix danger

chore: fix ci

chore: fix danger

refactor: tweaks

* chore: workspace deps

* chore: add changeset

* chore: v1.0.0-rc.2

* chore: fix versions

* chore: fix version deps between packages

* chore: v1.0.0-rc.3

* fix: iso date milliseconds regex (#481)

* chore: check deps consistency (#482)

* chore: pdate deps 2024-05-09 (#484)

* chore: update deps

* chore: fix lint

* chore: update danger (#483)

chore: update danger.js

* chore: upgrade RN / test app (#485)

* chore: upgrade turbo

* chore: update React Native / test app

* chore: fix wasm error

* chore: updata other deps (#486)

* chore: update other deps

* chore: update peer deps

* chore: update deps

* feat: enable wasm by default (#488)

* chore: tweak workflow (#490)

* chore: tweak workflow

* chore: update docs

* chore: export types (#489)

* chore: export types

* chore: gen yarn.lock

* chore: tweaks docs

* refactor: rename types

* chore: add docs

* chore: clean scripts (#491)

* chore: clean scripts

* chore: tweak turbo

* chore: add missing changeset

* chore: v1.0.0-beta.4

* chore: regenerate yarn.lock

* feat: detect unnecessary render and warn user (#468)

* feat: detect unnecessary render and warn user

feat: capture json representations in an array to compare after for unnecessary rendering

fix: get current testingLibrary for comparasion only react-native for now

fix: save json representation instead of string for rendered component state and compare changes between states using dfs

fix: test name

fix: update comparasion function and save compare results into output.json and show comparation results in the end of the test

fix: update interface and variable names based on pr recommendatations

chore: rebase to v1

* refactor: improve output formatting

* refactor: fix typo

* refactor: remove unnecessary warning

* refactor: improve testing

* refactor: improve report criteria

* refactor: improve naming

* refactor: improve code structure & tests

* refactor: tweaks

* feat: improve markdown output

* refactor: custom tree comparer

* refactor: clean up code

* refactor: update JSON structure

* refactor: use "initial update count" naming

* chore: fix lint

* chore: improve tests

* refactor: tweaks

* docs: update

* refactor: self code review

* docs: tweaks

* chore: add changeset

* refactor: final tweaks

---------

Co-authored-by: Guven Karanfil <guven.karanfil@smartface.io>
Co-authored-by: Maciej Jastrzebski <mdjastrzebski@gmail.com>

* chore: v1.0.0-rc.5

* chore: fix yarn.lock

* chore: fix reassure-tests.sh

---------

Co-authored-by: Güven Karanfil <40958989+guvenkaranfil@users.noreply.github.com>
Co-authored-by: Guven Karanfil <guven.karanfil@smartface.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mdjastrzebski