Add new mem:check task to run Valgrind in CI#26
Merged
Conversation
jbourassa
approved these changes
Nov 14, 2022
Collaborator
jbourassa
left a comment
There was a problem hiding this comment.
One question I have is: Should we run it on every PR, or no?
Given it's relatively fast, there's no harm in running it, no? Are you thinking it would be flaky?
241439d to
ce62743
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the great
ruby_memcheckgem into the repo. It's super powerful... I immediately found a memory leak in magnus and was able to fix it.As of this PR, there are no leaks detected, so we should be good to integrate into CI. One question I have is: Should we run it on every PR, or no? I'm thinking that might be too much, but we should at least run it on
main. Thoughts?