Include Rack::Response::Helpers in responses#99
Open
scttnlsn wants to merge 1 commit intobrooklynDev:masterfrom
Open
Include Rack::Response::Helpers in responses#99scttnlsn wants to merge 1 commit intobrooklynDev:masterfrom
scttnlsn wants to merge 1 commit intobrooklynDev:masterfrom
Conversation
Author
|
Fixed the merge conflicts here. Any interest in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes
Rack::Response::Helpersmethods in the Airborne responses. This enables the use of matchers like those commonly used withActionDispatch::TestResponse.i.e.
A few other notes:
rest_client_optionssetting (currently being used to setmax_redirects)base.rb. I was encountering an issue in the specs where onceAirborne.configuration.rack_appwas set it impacted other specs (that expected this value to benil). I believe this issue is not showing itself on master sincerack_sinatra_spec.rbis loaded last.