Skip to content

Conversation

@leogdion
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #5 into feature/authentication-integration will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                        Coverage Diff                         @@
##           feature/authentication-integration      #5   +/-   ##
==================================================================
  Coverage                                0.00%   0.00%           
==================================================================
  Files                                      25      25           
  Lines                                     182     182           
==================================================================
  Misses                                    182     182           
Flag Coverage Δ
#amd64 0.00% <ø> (ø)
#arm64 0.00% <ø> (ø)
#bionic 0.00% <ø> (ø)
#focal 0.00% <ø> (ø)
#github 0.00% <ø> (ø)
#macOS 0.00% <ø> (ø)
#travis 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd10258...91af9bf. Read the comment docs.

@leogdion leogdion merged commit c6976de into feature/authentication-integration Sep 10, 2020
leogdion added a commit that referenced this pull request Sep 11, 2020
* Feature/readme (#5)

* added logo and fixed badges

* Added Feature List

* Update macOS.yml

* Update arm.yml

* Update arm.yml

* added authentication parsing

* setting up server

* cleaning up code

* refactoring authentication

* refactoring authentication

* refactoring authentication

* refactoring authentication

* refactored HTTPServer

* removed MKResult

* fixing code factor trailing spaces

* fixing white space issues
@leogdion leogdion deleted the feature/readme branch September 14, 2020 15:57
leogdion added a commit that referenced this pull request Aug 29, 2025
* Feature/readme (#5)

* added logo and fixed badges

* Added Feature List

* Update macOS.yml

* Update arm.yml

* Update arm.yml

* added authentication parsing

* setting up server

* cleaning up code

* refactoring authentication

* refactoring authentication

* refactoring authentication

* refactoring authentication

* refactored HTTPServer

* removed MKResult

* fixing code factor trailing spaces

* fixing white space issues
@claude claude bot mentioned this pull request Nov 5, 2025
leogdion added a commit that referenced this pull request Nov 6, 2025
Implements first 8 fixes from PR #132 code review (Priority 0 items #4-6).

## Type System Migration (Int64 → Int)
- Update RestoreImageRecord.fileSize: Int64 → Int
- Update XcodeVersionRecord.fileSize: Int64? → Int?
- Remove unnecessary Int(record.fileSize) conversions in RecordBuilder
- Update IPSWFetcher, AppleDBFetcher, IPSWVersion to use Int
- Rename FieldValueExtensions.int64Value → intValue (+ 2 usage updates)

## Boolean Helper Usage
- Replace manual `.int64(bool ? 1 : 0)` with `.boolean(bool)` in RecordBuilder (4 locations)
- Move FieldValue.boolean() to extension for SwiftLint type_contents_order compliance

## Critical Bug Fixes
- Fix force unwrap crash risk in XcodeReleasesFetcher.toDate (use nil-coalescing)
- Fix duplicate BushelCloudKitService initialization in SyncEngine (reuse single instance)
- Remove silent error swallowing (try? → direct assignment)

## Build Status
✅ Clean build (3.81s) with no errors

Related to: #132 (items #1, #4, #5, #6, #10)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants