Skip to content

Comments

Fix signed/unsigned comparison#76

Merged
klemens-morgenstern merged 1 commit intoboostorg:developfrom
orgads:patch-1
Mar 22, 2019
Merged

Fix signed/unsigned comparison#76
klemens-morgenstern merged 1 commit intoboostorg:developfrom
orgads:patch-1

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented Mar 20, 2019

No description provided.

@klemens-morgenstern
Copy link
Collaborator

Thanks but I fear other tools will then complain about the C-style cast. Will add a static cast there.

@orgads
Copy link
Contributor Author

orgads commented Mar 20, 2019

That's not C-Style, it's function-style, which is C++.

But if you prefer static_cast I'm fine with it.

@klemens-morgenstern
Copy link
Collaborator

You're right, but a compiler might still warn about this. I personally don't mind that for brevity sake. But you know, you'd replace one warning with another warning. If you change it, I'll merge it, otherwise I'll add it in the next days myself. Thanks!

@orgads
Copy link
Contributor Author

orgads commented Mar 21, 2019

I don't know any compiler that warns about it. It's just like any other ctor call. But I suppose you'd want static_cast anyway for consistency, so there you have it :)

@klemens-morgenstern klemens-morgenstern merged commit 0485459 into boostorg:develop Mar 22, 2019
@orgads orgads deleted the patch-1 branch March 23, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants