Fix signed/unsigned comparison#76
Merged
klemens-morgenstern merged 1 commit intoboostorg:developfrom Mar 22, 2019
Merged
Conversation
Collaborator
|
Thanks but I fear other tools will then complain about the C-style cast. Will add a static cast there. |
Contributor
Author
|
That's not C-Style, it's function-style, which is C++. But if you prefer static_cast I'm fine with it. |
Collaborator
|
You're right, but a compiler might still warn about this. I personally don't mind that for brevity sake. But you know, you'd replace one warning with another warning. If you change it, I'll merge it, otherwise I'll add it in the next days myself. Thanks! |
Contributor
Author
|
I don't know any compiler that warns about it. It's just like any other ctor call. But I suppose you'd want static_cast anyway for consistency, so there you have it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.